Quality of Life improvement to Tracing View#600
Merged
KirillOsenkov merged 7 commits intoKirillOsenkov:mainfrom Jun 1, 2022
Merged
Quality of Life improvement to Tracing View#600KirillOsenkov merged 7 commits intoKirillOsenkov:mainfrom
KirillOsenkov merged 7 commits intoKirillOsenkov:mainfrom
Conversation
Contributor
yuehuang010
commented
Jun 1, 2022
- Fix the strange stacking of text. The previous indent logic assumes that the parent node is always bigger than the child indent. However, due to 1) strange timing between nodes, and 2) yielding, the nodes could be created in any side or order.
- Add Other text and counter. Add check to avoid redraw if nothing has changed.
- Fix an spacing issue when drawing the ruler.
- Sort lanes based on start time instead of node number itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.