Add UK National Insurance number generator#89
Merged
pimjansen merged 2 commits intoFakerPHP:mainfrom Dec 1, 2020
krsriq:FEAT/add_uk_nino
Merged
Add UK National Insurance number generator#89pimjansen merged 2 commits intoFakerPHP:mainfrom krsriq:FEAT/add_uk_nino
pimjansen merged 2 commits intoFakerPHP:mainfrom
krsriq:FEAT/add_uk_nino
Conversation
Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
IonBazan
reviewed
Nov 30, 2020
| do { | ||
| $prefixLetters = strtoupper(static::lexify('??')); | ||
| } while ( | ||
| in_array($prefixLetters[0], ['D', 'F', 'I', 'Q', 'U', 'V']) |
There was a problem hiding this comment.
how about choosing a random element from: ['?O', '?D', ?'F', ?'I', '?Q', ?'U', '?V', 'D?', 'F?', 'I?', 'Q?', 'U?', 'V?', 'BG', 'GB', 'NK', 'KN', 'TN', 'NT', 'ZZ'] instead and then using lexify on the result?
Never mind, the condition is opposite 🤦♂️
Member
|
Looks good to me, can you also document this in https://github.com/FakerPHP/fakerphp.github.io? |
Author
Yes, will do! |
pimjansen
approved these changes
Dec 1, 2020
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR