Feat/add at ssn#79
Conversation
Apply fixes from StyleCI
Apply fixes from StyleCI
Co-authored-by: Bram Ceulemans <bramceulemans@me.com>
Apply fixes from StyleCI
|
No need to enable StyleCI on the fork. In fact, it is discouraged. |
@GrahamCampbell Sorry, was not aware of that - disabled StyleCI now on my fork. |
Signed-off-by: Daniel Schmelz <q2CIa2U7>
|
Thanks! |
IonBazan
left a comment
There was a problem hiding this comment.
Sorry for reopening the discussion but there are some things I would improve but I missed the PR merge.
| */ | ||
| public static function ssn() | ||
| { | ||
| $birthdate = (new \DateTime('@' . mt_rand(0, time())))->format('dmy'); |
There was a problem hiding this comment.
Use Faker\Provider\DateTime::dateTimeThisCentury() instead and allow to customize the birth date
| $birthdate = (new \DateTime('@' . mt_rand(0, time())))->format('dmy'); | ||
|
|
||
| do { | ||
| $consecutiveNumber = (string) mt_rand(100, 999); |
There was a problem hiding this comment.
You can use self::numberBetween(100, 999) instead to avoid mt_rand() usage
|
Both suggestions sound good to me. Will you make a PR or shall I? |
|
@bramceulemans I'm on it. |
|
@krsriq can you also document this in https://github.com/FakerPHP/fakerphp.github.io? |
This PR:
Adds Austrian social security number.