updated Polish data#70
Merged
pimjansen merged 1 commit intoFakerPHP:mainfrom Nov 30, 2020
Merged
Conversation
Member
|
Thanks for your contribution, can you provide a source of your changes please. @IonBazan, can you maybe check this as well? |
IonBazan
approved these changes
Nov 26, 2020
IonBazan
left a comment
There was a problem hiding this comment.
Looks okay but please provide an updated source for Macedonia name change and for cities list - I was not able to find it on Poczta-Polska website.
| 'Radom','Radomsko','Ruda Śląska','Rumia','Rybnik','Rynarzewo','Rzeszów','Sandomierz','Sanok', | ||
| 'Siedlce','Siemianowice Śląskie','Sieradz','Skalbmierz','Skarżysko-Kamienna','Skierniewice', | ||
| 'Słupsk','Sochaczew','Sopot','Sosnowiec','Stalowa Wola','Starachowice','Stargard Szczeciński', | ||
| 'Słupsk','Sochaczew','Sopot','Sosnowiec','Stalowa Wola','Starachowice','Stargard', |
There was a problem hiding this comment.
Confirmed, city name changed in 2015.
Author
|
For banks I've used the same link @IonBazan used 3 years ago. The link is in the code so I've just updated the data. |
Member
|
I agree, let's stick to the international standards.
…On Fri, Nov 27, 2020, 16:22 Pim Jansen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/Faker/Provider/pl_PL/Address.php
<#70 (comment)>:
> @@ -37,7 +37,7 @@ class Address extends \Faker\Provider\Address
'Jamajka', 'Japonia', 'Jemen', 'Jordania', 'Kambodża', 'Kamerun', 'Kanada', 'Katar', 'Kazachstan', 'Kenia',
'Kirgistan', 'Kiribati', 'Kolumbia', 'Komory', 'Kongo', 'Korea Południowa', 'Korea Północna', 'Kostaryka',
'Kuba', 'Kuwejt', 'Laos', 'Lesotho', 'Liban', 'Liberia', 'Libia', 'Liechtenstein', 'Litwa', 'Luksemburg',
- 'Łotwa', 'Macedonia', 'Madagaskar', 'Malawi', 'Malediwy', 'Malezja', 'Mali', 'Malta', 'Maroko', 'Mauretania',
+ 'Łotwa', 'Macedonia Północna', 'Madagaskar', 'Malawi', 'Malediwy', 'Malezja', 'Mali', 'Malta', 'Maroko', 'Mauretania',
I want to follow the ISO here though since we do not want to end up in
political stuff
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#70 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADFQHIY7GYSVAYSZWLTZCSDSR67ZVANCNFSM4UC67V4Q>
.
|
pimjansen
requested changes
Nov 29, 2020
| @@ -9,72 +9,73 @@ class Payment extends \Faker\Provider\Payment | |||
| */ | |||
| protected static $banks = [ | |||
Author
There was a problem hiding this comment.
Yes, look into PHPDoc above. I've just updated the data from this source.
pimjansen
approved these changes
Nov 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: