Added excludes for BC#432
Merged
bram-pkg merged 1 commit intoFakerPHP:mainfrom Jan 23, 2022
pimjansen:feature/bc-check-fixes
Merged
Added excludes for BC#432bram-pkg merged 1 commit intoFakerPHP:mainfrom pimjansen:feature/bc-check-fixes
bram-pkg merged 1 commit intoFakerPHP:mainfrom
pimjansen:feature/bc-check-fixes
Conversation
Author
|
Hmm something still wrong with the new regexes though, have to review locally |
Author
|
@GrahamCampbell @bram-pkg ready for review. After that the broken builds can be rebased on main. |
bram-pkg
approved these changes
Jan 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Exclude the BC issues for experimental features
Author's checklist
Review checklist