add support for psr/container >= 2.0#354
add support for psr/container >= 2.0#354pimjansen merged 3 commits intoFakerPHP:mainfrom Lctrs:feature/psr-container/v2
Conversation
I don't think so: https://3v4l.org/aDKoX. |
Hmmm, I must have done something wrong. |
|
@GrahamCampbell Do you want me to create another PR for dropping support for PHP 7.1 ? |
|
Hmm, not sure. The tests don't seem to be failing here on PHP 7.1. |
|
I'm happy with this after my adjustments. This is not BC breaking. :) |
|
Lgtm |
|
Lgtm Lctrs |
|
This won't be v1.15.1. We follow semver, so this must be v1.16.0. There's no rush to tag here. You can install this using |
|
It's for Lctrs/psalm-psr-container-plugin#300, i doubt @Lctrs will set it's dependency on faker to a dev version 😛 |
|
I'm not in a rush as well. I'll actually set it to a dev version to unlock you @hannesvdvreken and not bother Faker's maintainers. |

What is the reason for this PR?
Make the project compatible with
psr/container>=2.0Author's checklist
Summary of changes
Updated
Faker\Extension\Containerto be compatible withpsr/container>= 2.0 .Tested that static analysis still pass with
psr/container1.0 (on PHP 7.4).Review checklist