Updated LV last names from different source#312
Merged
pimjansen merged 1 commit intoFakerPHP:mainfrom Apr 28, 2021
Merged
Conversation
Member
|
Looks good to me, please refrain from having an empty description and use this format: ### What is the reason for this PR?
<!-- Explain your goals for this PR -->
- [ ] A new feature
- [ ] Fixed an issue (resolve #ID)
### Author's checklist
- [ ] Follow the [Contribution Guide](https://github.com/FakerPHP/Faker/blob/main/.github/CONTRIBUTING.md)
- [ ] New features and changes are [documented](https://github.com/FakerPHP/fakerphp.github.io)
### Summary of changes
<!-- Give a quick explanation about your code changes here -->
### Review checklist
- [ ] All checks have passed
- [ ] Changes are approved by maintainer |
bram-pkg
approved these changes
Apr 27, 2021
pimjansen
approved these changes
Apr 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Latvian last names were only about 50. I provided the list with about 500 last names.
Author's checklist
Summary of changes
Now you can generate better latvian last names.
Review checklist