Skip to content

Updated LV last names from different source#312

Merged
pimjansen merged 1 commit intoFakerPHP:mainfrom
janiseglitis:patch-1
Apr 28, 2021
Merged

Updated LV last names from different source#312
pimjansen merged 1 commit intoFakerPHP:mainfrom
janiseglitis:patch-1

Conversation

@janiseglitis
Copy link
Copy Markdown

@janiseglitis janiseglitis commented Apr 26, 2021

What is the reason for this PR?

Latvian last names were only about 50. I provided the list with about 500 last names.

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Summary of changes

Now you can generate better latvian last names.

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@bram-pkg
Copy link
Copy Markdown
Member

bram-pkg commented Apr 27, 2021

Looks good to me, please refrain from having an empty description and use this format:

### What is the reason for this PR?

<!-- Explain your goals for this PR -->

- [ ] A new feature
- [ ] Fixed an issue (resolve #ID)

### Author's checklist

- [ ] Follow the [Contribution Guide](https://github.com/FakerPHP/Faker/blob/main/.github/CONTRIBUTING.md)
- [ ] New features and changes are [documented](https://github.com/FakerPHP/fakerphp.github.io)

### Summary of changes

<!-- Give a quick explanation about your code changes here -->

### Review checklist

- [ ] All checks have passed
- [ ] Changes are approved by maintainer

@pimjansen pimjansen merged commit 8760b4a into FakerPHP:main Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants