For the ones that get worse, this is due the fact that no return type has been specified on the methods itself. Do we want to drag this into scope or not? If yes then we need to modify those blocks as well

@localheinz can you assist in the weird phpstan error? Can't resolve it somehow. Also when running it locally im getting phpstan errors.

Note: Using configuration file /home/pim/Projects/Faker/phpstan.neon.dist.
 478/478 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 -- -------------------------------------------------------------------------------------------------------------------- 
     Error                                                                                                               
 -- -------------------------------------------------------------------------------------------------------------------- 
     Reached internal errors count limit of 50, exiting...                                                               
     Internal error: Internal error: preg_replace(): Argument #3 ($subject) must be of type array|string, null given in  
     file /home/pim/Projects/Faker/src/Faker/Provider/hr_HR/Address.php     

Could be the fact that its running php 8 locally though.

@pimjansen

Can you verify whether you have Xdebug enabled? Disabling it should fix the error.

As @bramceulemans suggested, you should be able to regenerate the baseline afterwards!

@pimjansen

What do you think about running the script that updates the DocBlock in GitHub Actions?

This way we could ensure that

• the script works
• the script is run when changes were made

@pimjansen

What do you think about running the script that updates the DocBlock in GitHub Actions?

This way we could ensure that

• the script works

• the script is run when changes were made

Could do but maybe its a bit too much magic and it reduces the actual understanding what everything does imo.

Concerning the issue, the error is a bit odd since the method actually is no phpdoc defined that gives the error. But let me run without xdebug

@localheinz seems that PHPstan version is not running fine on PHP8. Lets modify that in the future. I will downgrade locally to 7.4 instead where it runs fine

Do you known when this will be released ?

Unknown yet. Since its not a bug we are not pushing an extra release for this

It's still pretty inconvenient. Please consider it, unless you're close to your next release. Also you should probably not close issues like #303 until this is merged into main: it gives the false impression the issue is fixed while it isn't. You can use closing keywords in your PR description like "Fix #303" for it to automatically happen upon merge.

@pimjansen any chance to tag a release including that fix ? It's been more than 2 months since the fix was done now.
Without this fix, we must choose between running static analysis and migrating away from the deprecated properties, but we cannot have a nice state.

@pimjansen any chance to tag a release including that fix ? It's been more than 2 months since the fix was done now.
Without this fix, we must choose between running static analysis and migrating away from the deprecated properties, but we cannot have a nice state.

#342

There's one thing that got worse in this update: unique() and optional() have been updated to document their return type as UniqueGenerator and DefaultGenerator. But those 2 classes don't have the magic methods documented on them.
Previously, the magic methods were documented as returning Generator

Hey, something else is broken here. Was using the shuffle() method to shuffle a string. Worked fine in v14, but v15 gives an error with PHPStan, because the return type was changed from array|string to array, which is incorrect. I'm guessing it was a mistake?