Added a note about our BC promise#273
Merged
bram-pkg merged 2 commits intoFakerPHP:mainfrom Feb 4, 2021
Merged
Conversation
Member
|
This should probably go in the contribution guide. In fact, I think some of this already is? |
|
Shouldnt we add it in both? Since it will also be relevant for regular use that will just consume only |
Member
Author
|
Oh. Is it? It really shouldn't be there. :) It is a promise to all our users. Not just the contributors. I'll update the PR |
Member
|
The addition of this section looks good to me. |
bram-pkg
approved these changes
Jan 30, 2021
bram-pkg
requested changes
Jan 30, 2021
|
Lgtm except the comment of bram |
bram-pkg
approved these changes
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should clearly state what is included and what is not included in our BC promise.