Skip to content

Fix U.S. Area Code Generation#261

Merged
pimjansen merged 1 commit intoFakerPHP:mainfrom
localheinz:fix/phone
Jan 8, 2021
Merged

Fix U.S. Area Code Generation#261
pimjansen merged 1 commit intoFakerPHP:mainfrom
localheinz:fix/phone

Conversation

@localheinz
Copy link
Copy Markdown
Member

@localheinz localheinz commented Jan 8, 2021

See fzaninotto#1838:

Regular expressions extracted from the PHP port of Google's libphonenumber via the PHP port:
https://github.com/giggsey/libphonenumber-for-php/blob/f3a55dcb6fead9d4fb291c6dadda0564e5ae8d3f/src/data/PhoneNumberMetadata_US.php#L29

What is the reason for this PR?

Author's checklist

Summary of changes

Replaces fzaninotto#1838.

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@localheinz localheinz added the bug Something isn't working label Jan 8, 2021
@pimjansen pimjansen merged commit 9328e44 into FakerPHP:main Jan 8, 2021
@localheinz localheinz deleted the fix/phone branch January 9, 2021 01:38
@localheinz
Copy link
Copy Markdown
Member Author

Thank you, @pimjansen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generates invalid US phone numbers

3 participants