What is the reason for this PR?

There's a bug in Helper::numerify caused by a - compared to Base::numerify - changed use of mt_rand:
Base::numerify uses randomNumber($size), where the argument $size is the number of digits while Helper::numerify uses mt_rand(0, $size), where $size is the highest possible value to be returned.

Thus executing Helper::numerify(str_repeat('#', 10)) always returns strings like 0000000050:

Factory::create()->seed(1);
echo Helper::numerify(str_repeat('#', 10)); // "0000000050"
echo BaseProvider::numerify(str_repeat('#', 10)); // "7203244899"

• Fixed an issue

Author's checklist

• Follow the Contribution Guide
• New features and changes are documented

Summary of changes

This PR fixes the issue and adds a test to verify functionality. The test is based on a very high probability that Helper::numerify(str_repeat('#', 10)) should return large numbers.

Since mt_rand(0, 10 ** $size - 1) is not as easy to read as static::randomNumber($size) (at least for me), I'd be in favor of replacing the change done with this PR once the number extension is implemented, but this is out of scope for this bugfix PR.

Review checklist

• All checks have passed
• Changes are approved by maintainer