Adding trait for GeneratorAwareExtension#165
Merged
localheinz merged 4 commits intoFakerPHP:mainfrom Dec 22, 2020
Merged
Conversation
localheinz
reviewed
Dec 21, 2020
localheinz
reviewed
Dec 21, 2020
121eec0 to
fe9263e
Compare
fe9263e to
69ed9b9
Compare
Member
|
I removed an unnecessary property initialization and added a test - do you want to take a look? |
384dceb to
d5a393e
Compare
localheinz
approved these changes
Dec 22, 2020
Member
|
Thank you, @Nyholm! |
Member
Author
|
Thank you for improving the PR and for merging |
krsriq
pushed a commit
to krsriq/Faker
that referenced
this pull request
Jan 7, 2021
* Adding trait for GeneratorAwareExtension * Fixes * Fix: Remove unnecessary initialization * Fix: Add test Co-authored-by: Andreas Möller <am@localheinz.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #154