Deprecate zh_TW methods that only call base methods#122
Merged
pimjansen merged 3 commits intoFakerPHP:mainfrom Dec 20, 2020
Merged
Deprecate zh_TW methods that only call base methods#122pimjansen merged 3 commits intoFakerPHP:mainfrom
pimjansen merged 3 commits intoFakerPHP:mainfrom
Conversation
Member
|
Looks good to me. |
bram-pkg
approved these changes
Dec 9, 2020
GrahamCampbell
requested changes
Dec 9, 2020
pimjansen
approved these changes
Dec 20, 2020
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
In
zh_TWthere are two classes that useFactory::create('en_US')only to call base methods.Author's checklist
Summary of changes
This PR deprecates these classes and methods. For BC the respective parent methods are called.
Review checklist