Fix height paragraph box height calculation#810
Merged
Conversation
The insets were removed from the "overhead" when they should have been added. This was asking the text for its preferred height if it had (width + insets) space, rather than (width - insets). Because of this, some paragraphs give a preferred height of one line less than they should (because they wouldn't need to wrap given the extra space that's actually occupied by the insets). Closes FXMisc#809
Collaborator
|
@csmith thanks alot for the PR and fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The insets were removed from the "overhead" when they should have been
added. This was asking the text for its preferred height if it had
(width + insets) space, rather than (width - insets).
Because of this, some paragraphs give a preferred height of one line
less than they should (because they wouldn't need to wrap given the
extra space that's actually occupied by the insets).
Fixes #809