Skip to content

Fixes #774#775

Merged
Jugen merged 4 commits into
FXMisc:masterfrom
obcardinal:master
Nov 4, 2018
Merged

Fixes #774#775
Jugen merged 4 commits into
FXMisc:masterfrom
obcardinal:master

Conversation

@obcardinal

Copy link
Copy Markdown

No description provided.

@Jugen

Jugen commented Sep 7, 2018

Copy link
Copy Markdown
Collaborator

@MrChebik Thanks for the patch and pull request, however your changes causes the following two tests to fail:

  1. PositionTests.end_position_is_correct_when_change_occurs_at_position @ line 137
  2. PositionTests.end_position_is_correct_when_change_occurs_after_position @ line 153

Please review your fix so that all tests pass :-)
Thank you.

@goxr3plus

Copy link
Copy Markdown
Collaborator

@Jugen Tests are now passing .

@rustem-s

Copy link
Copy Markdown

Dear @Jugen!
When you approve this pull request?
This bug also bothers us.

@obcardinal

obcardinal commented Oct 25, 2018

Copy link
Copy Markdown
Author

Hi, @rustem-s, you can use forked project with bug fix.

<repositories>
    <repository>
        <id>jitpack.io</id>
        <url>https://jitpack.io</url>
    </repository>
</repositories>

// ...

<dependency>
    <groupId>com.github.MrChebik</groupId>
    <artifactId>RichTextFX</artifactId>
    <version>cabee30961</version>
</dependency>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants