add option to use --signoff with git commit#46
Conversation
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
EndBug
left a comment
There was a problem hiding this comment.
Hi, thanks for the PR, but I have some questions:
- I've run a couple of tests with your code, and it doesn't seem to commit correctly. Could you link me to the tests you ran so that I can confront them?
- The new option would only add an argument to the
git addcommand, wouldn't it be easier to just add it in theaddoption (likesrc --signoff)? If not, are there any issues in doing so?
I know that the --force parameter has its own option in this action, but I feel like it would be better to just add a field that you can use to put your custom options, if that can't already be achieved by using the add field.
|
I have tested it by changing the The aim of the |
|
Sorry, my bad:
|
EndBug
left a comment
There was a problem hiding this comment.
I think the problem was caused by the fact that you used double quotes with the sign off variable.
I've also refactored the code to make it look like the add function.
You're welcome to give it a check, if that works for you I'll publish it in the next minor version ;)
|
I am ok with the changes. Thank you for the help. |
|
@all-contributors please add @pvogt09 for code |
|
I've put up a pull request to add @pvogt09! 🎉 |
|
Ok, you can find the new feature in version Thanks again for your contribution ✨ |
This PR adds the ability to
--signoffthe created commit by introducing a new optionssignoff.