Skip to content

feat: allow specifying a path to flake.nix within the repository#52

Merged
cole-h merged 1 commit intoDeterminateSystems:mainfrom
aanderse:main
Sep 14, 2022
Merged

feat: allow specifying a path to flake.nix within the repository#52
cole-h merged 1 commit intoDeterminateSystems:mainfrom
aanderse:main

Conversation

@aanderse
Copy link
Copy Markdown
Contributor

@aanderse aanderse commented Sep 9, 2022

Description

Allow specifying a path to flake.nix within the repository - resolves #50. I ran a single test where I used the path-to-flake-nix input and it performed as expected.

Checklist
  • Tested functionality against a test repository (see "How to test changes")
  • Added or updated relevant documentation (leave unchecked if not applicable)

@cole-h cole-h self-requested a review September 11, 2022 22:03
Copy link
Copy Markdown
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I wonder if I could cajole you into writing a brief section in the README, or even just add its usage to one of the existing examples.

EDIT: "no" is also fine, just let me know and I'll tackle it!

@aanderse
Copy link
Copy Markdown
Contributor Author

Thanks for the feedback. I'll address in the next day or two. 🚀

@aanderse
Copy link
Copy Markdown
Contributor Author

@cole-h please feel free to suggest or make any additional changes.

Copy link
Copy Markdown
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I was a bit busy yesterday and forgot to get back to you -- sorry!

LGTM!

@cole-h cole-h merged commit 0ad9a55 into DeterminateSystems:main Sep 14, 2022
@aanderse
Copy link
Copy Markdown
Contributor Author

Thanks @cole-h!

@cole-h
Copy link
Copy Markdown
Member

cole-h commented Sep 14, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow specifying a path to flake.nix within the repository

2 participants