Skip to content

Add analyzer for incorrect [INotifyPropertyChanged] and [ObservableObject] use#531

Merged
Sergio0694 merged 3 commits intomainfrom
dev/base-attribute-analyzer
Dec 12, 2022
Merged

Add analyzer for incorrect [INotifyPropertyChanged] and [ObservableObject] use#531
Sergio0694 merged 3 commits intomainfrom
dev/base-attribute-analyzer

Conversation

@Sergio0694
Copy link
Copy Markdown
Member

Closes #530

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Dec 11, 2022
Copy link
Copy Markdown
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple typos, otherwise looks good

@Sergio0694 Sergio0694 force-pushed the dev/base-attribute-analyzer branch from 5fd2c8a to e3980a7 Compare December 12, 2022 19:16
@Sergio0694 Sergio0694 merged commit aa4ff30 into main Dec 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/base-attribute-analyzer branch December 12, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

analyzer 👓 A new analyzer being implemented or updated mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add analyzer to warn when [INotifyPropertyChanged] & co. are used when not needed

2 participants