Add method for formatting licenses #10940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
seems good to me. |
Contributor
|
Can you add an enhancement in |
Contributor
Author
Added |
dnkoutso
reviewed
Sep 12, 2021
CHANGELOG.md
Outdated
| ##### Enhancements | ||
|
|
||
| * None. | ||
| * Add method for formatting licenses for acknowledgements generation. |
Contributor
There was a problem hiding this comment.
sorry, one more thing, this needs to have 2 empty spaces at the end for proper markdown formatting. I think also if possible add a link to this pull request as the other entries do. Thanks!
Contributor
Author
There was a problem hiding this comment.
Should be good now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can change the footer / header as per https://blog.cocoapods.org/Acknowledgements/
But we can't touch the license itself besides copy pasting the entire private method.
Add a method such that we can format license texts without having to copy the entire private method