Fix Bug in Ignoring Response Body#31952
Merged
alzimmermsft merged 2 commits intoAzure:mainfrom Nov 4, 2022
Merged
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
lmolkova
approved these changes
Nov 4, 2022
lmolkova
left a comment
There was a problem hiding this comment.
Can you please create another task to test this behavior?
Member
Author
Tests will be added in the next push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug when the HTTP response was being ignored to treat it as the same as eagerly reading the response, again. The
JdkHttpClientwas fixed to no longer useFluxUtil.collectBytesFromNetworkResponsewhich was the root of the issue for why ignoring response was added.The bug found was in Storage when a void response method had an exception a response body would be returned containing the error message.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines