Skip to content

Conversation/Dialogue: handling participants enhancements #18438

Merged
retrofox merged 5 commits intomasterfrom
update/coversation-dialogue-participants
Jan 21, 2021
Merged

Conversation/Dialogue: handling participants enhancements #18438
retrofox merged 5 commits intomasterfrom
update/coversation-dialogue-participants

Conversation

@retrofox
Copy link
Copy Markdown
Contributor

@retrofox retrofox commented Jan 19, 2021

This PR introduces some changes in order to enhance the block participants edition. Most releat changes:

  • Remove participants dropdown from the editor canvas
    The participants dropdown has been removed from the editor canvas, in the Dialogue context.

  • Add participants dropdown in the block toolbar.

  • Remove custom participant from Dialogue block:
    All participants belong to the conversation block, which means are edited globally in that context. From the Dialogue context, the user just can pick up from the block toolbar.

Screenshot

Fixes #18283

Changes proposed in this Pull Request:

  • Conversation/Dialogue: handling participants enhancements

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Create a conversation block with some dialogue blocks there
  • Confirm the changes introduced by this PR

Dialogue - Editor Canvas / Block Toolbar

Before After
image image

Dialogue - Sidebar

Before After
image image

Proposed changelog entry for your changes:

  • n/a

@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Jan 19, 2021

Caution: This PR has changes that must be merged to WordPress.com
Hello retrofox! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D55656-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@retrofox retrofox mentioned this pull request Jan 19, 2021
Closed
@retrofox retrofox requested review from a user January 19, 2021 21:15
@retrofox retrofox self-assigned this Jan 19, 2021
@retrofox retrofox added [Block] Conversation [Block] Dialogue [Status] Needs Team Review Obsolete. Use Needs Review instead. Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Jan 19, 2021
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Jan 19, 2021 •
edited
Loading

Scheduled Jetpack release: February 2, 2021.
Scheduled code freeze: January 25, 2021

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against dd7c628

allilevine
allilevine requested changes Jan 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of questions about the UI but otherwise this works as expected. 👍

Comment thread projects/plugins/jetpack/extensions/blocks/dialogue/edit.js
onChange={ setAttributes }
/>
</div>
<Button
Copy link
Copy Markdown
Member

@allilevine allilevine Jan 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a text element now, instead of a Button?

Copy link
Copy Markdown
Contributor Author

@retrofox retrofox Jan 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still possible to edit the participant style by focusing on the participant name. In order to make it accessible, I opted to render it with a Button. You can focus it by clicking on it, or pressing the tab key in the right context.

In short, I think we should keep the button there.

Copy link
Copy Markdown
Contributor Author

@retrofox retrofox Jan 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've switched the toolbar groups:

Screen.Recording.2021-01-20.at.4.31.47.PM.mov

Comment thread projects/plugins/jetpack/extensions/blocks/dialogue/components/participants-control.js Outdated
allilevine
allilevine approved these changes Jan 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these changes I see the Participant drop-down on the Dialogue block toolbar and I can select different participants. ✅ Tested in self-hosted, Atomic, JN.

@retrofox retrofox added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Jan 20, 2021
@jeherve jeherve added this to the 9.4 milestone Jan 21, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jan 21, 2021
@retrofox
Copy link
Copy Markdown
Contributor Author

retrofox commented Jan 21, 2021

r219786-wpcom

@retrofox retrofox merged commit b634795 into master Jan 21, 2021
@retrofox retrofox deleted the update/coversation-dialogue-participants branch January 21, 2021 12:39
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

@allilevine allilevine allilevine approved these changes

Assignees

@retrofox retrofox

Labels

[Block] Conversation [Block] Dialogue Enhancement Changes to an existing feature — removing, adding, or changing parts of it Touches WP.com Files

Projects

None yet

Milestone

9.4

Development

Successfully merging this pull request may close these issues.

Conversation/dialog blocks: edit participants from toolbar

5 participants

@retrofox @matticbot @jetpackbot @jeherve @allilevine