8058322: Zero name_index item of MethodParameters attribute cause MalformedParameterException.#63
Closed
liach wants to merge 1 commit into
Closed
Conversation
|
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue and summary from the original commit. |
|
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An out-of-spec behavior of core reflection causes it to fail when it encounters class files that conform to JVMS for release 8. In JVMS § 4.7.24 parameters are allowed to have
null(CP reference 0) names, but core reflection didn't accept it.This problem was relatively obscure, but it has been exacerbated when javac for release 21 and later starts generating such parameters in
MethodParametersattribute. Since this is a problem with Java 8, I propose to backport this related fix onto 8 instead of changing latest releases.This pull request contains a backport of commit cba5bd26 from the openjdk/jdk repository. The commit being backported was authored by Eric McCorkle on 11 Nov 2014 and was reviewed by Coleen Phillimore and David Holmes.
A backport request is included in the latest comment in the original JBS issue.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/63/head:pull/63$ git checkout pull/63Update a local copy of the PR:
$ git checkout pull/63$ git pull https://git.openjdk.org/jdk8u.git pull/63/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 63View PR using the GUI difftool:
$ git pr show -t 63Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/63.diff
Webrev
Link to Webrev Comment