Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2010463003: Fix webkit test expectations on 5.2 branch to handle for-in flag flip (Closed)

Created:
4 years, 7 months ago by adamk
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.2
Target Ref:
refs/pending/branch-heads/5.2
Project:
v8
Visibility:
Public.

Description

Fix webkit test expectations on 5.2 branch to handle for-in flag flip R=hablich@chromium.org, machenbach@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/89e4f0d73913c2ec6fa734789aaf120febdfd922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/webkit/fast/js/parser-syntax-check-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
adamk
4 years, 7 months ago (2016-05-24 19:19:42 UTC) #2
Michael Achenbach
lgtm
4 years, 7 months ago (2016-05-24 19:20:50 UTC) #4
Michael Hablich
On 2016/05/24 19:20:50, Michael Achenbach (slow) wrote: > lgtm lgtm
4 years, 7 months ago (2016-05-24 19:21:11 UTC) #5
adamk
4 years, 7 months ago (2016-05-24 19:25:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
89e4f0d73913c2ec6fa734789aaf120febdfd922.

Powered by Google App Engine
This is Rietveld 408576698