Feature: allow reference syntax #22

2025-12-06T13:05:31+01:00

joapuiib commented

2025-12-06 13:05:31 +01:00

(Migrated from github.com)

This PR allows using referenced link syntax with aliases, as proposed in #16.

The song references [Wuthering Heights][wuthering-heights].

[wuthering-heights]: [[wuthering-heights#references]]

Closes #16

This PR allows using referenced link syntax with aliases, as proposed in #16. ```md The song references [Wuthering Heights][wuthering-heights]. [wuthering-heights]: [[wuthering-heights#references]] ``` Closes #16

EddyLuten (Migrated from github.com) requested changes

2026-01-07 00:14:58 +01:00

EddyLuten (Migrated from github.com) left a comment

Thanks a bunch for implementing this feature. There are a few minor tweaks required before merging, but it's looking great!

alias/plugin.py

					
				@ -147,0 +171,4 @@

				    # Resolve the final URL and anchor

				    url = get_relative_url(alias['url'], page_file.src_uri)

				    if anchor:

This function will need a docstring added, or the linter will fail during build/CI.

test_plugin.py

					
				@ -6,7 +6,14 @@ import logging

				import re

The line length for this import is too long with the additions, so you may have to break it up to make the linter happy. In addition to running pytest locally, please also check pylint (pylint $(git ls-files '*.py') && pytest -vv) to prevent breaking the CI build process on merge.

The line length for this import is too long with the additions, so you may have to break it up to make the linter happy. In addition to running pytest locally, please also check pylint (`pylint $(git ls-files '*.py') && pytest -vv`) to prevent breaking the CI build process on merge.

test_plugin.py

It looks like the name of this test conflicts with the one right above it.

test_plugin.py:453:0: E0102: function already defined line 437 (function-redefined)

It looks like the name of this test conflicts with the one right above it. ``` test_plugin.py:453:0: E0102: function already defined line 437 (function-redefined) ```