[BUG] Incorrect syntax highlighting for .vue template directives #2945

Closed
opened 2024-04-01 13:04:42 +02:00 by Linneris · 4 comments

Description

In my project, .vue files that include a directive like v-if or v-for in the template have incorrect syntax highlighting.

Examples:

Expected behavior

The string literal syntax highlighting is only applied to the value of the v-if or v-for HTML attribute, and the rest of the file from that point is parsed correctly. In particular, the <script> section should have TypeScript syntax highlighting.

Actual behavior

Some v-if and v-for directives seem to break the syntax highlighting parser, and it assigns the string literal color to everything after the directive. It seems to happen when the directive is followed by more HTML attributes.

Screenshots

image

Forgejo Version

8.0.0-dev-46-75234fc6bc+gitea-1.22.0

Can you reproduce the bug on Forgejo Next?

Yes

Browser Version

Firefox 124.0.1 (Flatpak)

Operating System

Ubuntu 22.04

### Description In my project, `.vue` files that include a directive like `v-if` or `v-for` in the template have incorrect syntax highlighting. Examples: * https://next.forgejo.org/Linneris/central-archives/src/branch/main/client/src/components/communities/CommunityList.vue * https://next.forgejo.org/Linneris/central-archives/src/branch/main/client/src/components/event/EventView.vue #### Expected behavior The string literal syntax highlighting is only applied to the value of the `v-if` or `v-for` HTML attribute, and the rest of the file from that point is parsed correctly. In particular, the `<script>` section should have TypeScript syntax highlighting. #### Actual behavior Some `v-if` and `v-for` directives seem to break the syntax highlighting parser, and it assigns the string literal color to everything after the directive. It seems to happen when the directive is followed by more HTML attributes. ### Screenshots ![image](/attachments/28539763-5206-4640-9a2b-7b2debe061fb) ### Forgejo Version 8.0.0-dev-46-75234fc6bc+gitea-1.22.0 ### Can you reproduce the bug on Forgejo Next? Yes ### Browser Version Firefox 124.0.1 (Flatpak) ### Operating System Ubuntu 22.04
154 KiB
Owner

I've opened https://github.com/alecthomas/chroma/pull/950 that should fixes this. Thanks for reporting!

I've opened https://github.com/alecthomas/chroma/pull/950 that should fixes this. Thanks for reporting!
Owner

The PR is merged, now it's just waiting until Chroma releases a new version. That's the easy part :P

The PR is merged, now it's just waiting until Chroma releases a new version. That's the easy part :P
Author

The bugfix has been released as part of Chroma 2.14.0.

https://github.com/alecthomas/chroma/releases/tag/v2.14.0

The bugfix has been released as part of Chroma 2.14.0. https://github.com/alecthomas/chroma/releases/tag/v2.14.0
Author

Closing, since the fixed version of Chroma is now used in Forgejo:

e417e424fa

Closing, since the fixed version of Chroma is now used in Forgejo: https://codeberg.org/forgejo/forgejo/commit/e417e424fad0980d52ab5af8c9d57af2d89a959e
Sign in to join this conversation.
No labels
arch
riscv64
backport/v1.19
backport/v1.20
backport/v1.21/forgejo
backport/v10.0/forgejo
backport/v11.0/forgejo
backport/v12.0/forgejo
backport/v13.0/forgejo
backport/v14.0/forgejo
backport/v15.0/forgejo
backport/v7.0/forgejo
backport/v8.0/forgejo
backport/v9.0/forgejo
breaking
bug
bug
confirmed
bug
duplicate
bug
needs-more-info
bug
new-report
bug
reported-upstream
code/actions
code/api
code/auth
code/auth/faidp
code/auth/farp
code/email
code/federation
code/git
code/migrations
code/packages
code/wiki
database
MySQL
database
PostgreSQL
database
SQLite
dependency-upgrade
dependency
certmagic
dependency
chart.js
dependency
Chi
dependency
Chroma
dependency
citation.js
dependency
codespell
dependency
css-loader
dependency
devcontainers
dependency
dropzone
dependency
editorconfig-checker
dependency
elasticsearch
dependency
enmime
dependency
F3
dependency
ForgeFed
dependency
garage
dependency
Git
dependency
git-backporting
dependency
Gitea
dependency
gitignore
dependency
go-ap
dependency
go-enry
dependency
go-gitlab
dependency
Go-org
dependency
go-rpmutils
dependency
go-sql-driver mysql
dependency
go-swagger
dependency
go-version
dependency
go-webauthn
dependency
gocron
dependency
Golang
dependency
goldmark
dependency
goquery
dependency
Goth
dependency
grpc-go
dependency
happy-dom
dependency
Helm
dependency
image-spec
dependency
jsonschema
dependency
KaTeX
dependency
lint
dependency
MariaDB
dependency
Mermaid
dependency
minio-go
dependency
misspell
dependency
Monaco
dependency
PDFobject
dependency
playwright
dependency
postcss
dependency
postcss-plugins
dependency
pprof
dependency
prometheus client_golang
dependency
protobuf
dependency
relative-time-element
dependency
renovate
dependency
reply
dependency
ssh
dependency
swagger-ui
dependency
tailwind
dependency
temporal-polyfill
dependency
terminal-to-html
dependency
tests-only
dependency
text-expander-element
dependency
urfave
dependency
vfsgen
dependency
vite
dependency
Woodpecker CI
dependency
x tools
dependency
XORM
Discussion
duplicate
enhancement/feature
forgejo/accessibility
forgejo/branding
forgejo/ci
forgejo/commit-graph
forgejo/documentation
forgejo/furnace cleanup
forgejo/i18n
forgejo/interop
forgejo/moderation
forgejo/privacy
forgejo/release
forgejo/scaling
forgejo/security
forgejo/ui
Gain
High
Gain
Nice to have
Gain
Undefined
Gain
Very High
good first issue
i18n/backport-stable
impact
large
impact
medium
impact
small
impact
unknown
Incompatible license
issue
closed
issue
do-not-exist-yet
issue
open
manual test
Manually tested during feature freeze
OS
FreeBSD
OS
Linux
OS
macOS
OS
Windows
problem
QA
regression
release blocker
Release Cycle
Feature Freeze
release-blocker
v7.0
release-blocker
v7.0.1
release-blocker
v7.0.2
release-blocker
v7.0.3
release-blocker
v7.0.4
release-blocker
v8.0.0
release-blocker/v9.0.0
run-all-playwright-tests
run-end-to-end-tests
test
manual
test
needed
test
needs-help
test
not-needed
test
present
untested
User research - time-tracker
valuable code
worth a release-note
User research - Accessibility
User research - Blocked
User research - Community
User research - Config (instance)
User research - Errors
User research - Filters
User research - Future backlog
User research - Git workflow
User research - Labels
User research - Moderation
User research - Needs input
User research - Notifications/Dashboard
User research - Rendering
User research - Repo creation
User research - Repo units
User research - Security
User research - Settings (in-app)
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/forgejo#2945
No description provided.