Recover from GPU resets #601
Labels
No labels
A: maintenance
A: question
B: not applicable
B: not reproducible
B: resolved
C: multi-DPI
C: protocols
C: rendering
C: XWayland
Kind/Bug
Kind/Feature
Reviewed
Duplicate
Reviewed
Won't Fix
No milestone
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
dwl/dwl#601
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
While it seems relatively easy to implement, it requires a considerable amount of lines. And I'm not sure if we need it.
Sway PR: https://github.com/swaywm/sway/pull/8063
Sounds like a reasonable thing to need, and GPU's probably won't just stop resetting.
With
dwlthe worst thing that can happen is a full system freeze or a crash that takes down all your applications. So avoiding that is definitely an improvement.I’ll add that whenever dwl hangs/crashes it is almost always due to a gpu reset when I check dmesg. So +1000 to handling it even at the cost of loc.
+1
I had a freeze just yesterday during system update. This caused multiple issues but the most notable was the fact I couldn't get past cryptsetup, as it was one of those packages that got corrupted. Quick look for available USB stick and borrowing someone's PC -later I got my system fixed.
I highly recommend prioritising stability over LOC. I like my programs to be small but in this case I think it is best to go forward with this as a PR.
By the way. Does anybody know whether gpu (amd in my case) actually resets on it's own or we need some kernel parameters: https://github.com/ROCm/ROCm/issues/616. And whether SDDM or any login manager has to handle reset either?