Height hard set at number of lines #64

New issue

Closed

opened 2025-07-15 21:31:57 +02:00 by fictitiousexistence · 2 comments

fictitiousexistence commented

2025-07-15 21:31:57 +02:00

If I do
printf "test\ntest" | wmenu -l 50

the resulting wmenu window is 50 lines long covering the whole screen even when there are only 2 menu items.
Is this intended? I expected if the number of lines is less than the -l option then the wmenu window would only be big enough to show all the lines.

If I do `printf "test\ntest" | wmenu -l 50` the resulting wmenu window is 50 lines long covering the whole screen even when there are only 2 menu items. Is this intended? I expected if the number of lines is less than the -l option then the wmenu window would only be big enough to show all the lines.

adnano commented

2025-07-25 19:37:21 +02:00

Owner

Yes, this was intended. However, it seems dmenu doesn't behave this way. I'd be willing to accept a patch to bring wmenu's behavior in line with dmenu's.

fictitiousexistence commented

2025-07-26 15:23:11 +02:00

Author

I'm not a developer, this works but I'm sure it not correct?

diff --git a/menu.c b/menu.c
index 207d71c..1931976 100644
--- a/menu.c
+++ b/menu.c
@@ -181,6 +181,11 @@ void menu_add_item(struct menu *menu, char *text) {
 	new->text = text;
 
 	menu->item_count++;
+
+	if ((size_t)menu->lines > menu->item_count){
+		menu->height = menu->line_height;
+		menu->height += menu->height * menu->item_count;
+	}
 }
 
 static int compare_items(const void *a, const void *b) {

I'm not a developer, this works but I'm sure it not correct? ``` diff --git a/menu.c b/menu.c index 207d71c..1931976 100644 --- a/menu.c +++ b/menu.c @@ -181,6 +181,11 @@ void menu_add_item(struct menu *menu, char *text) { new->text = text; menu->item_count++; + + if ((size_t)menu->lines > menu->item_count){ + menu->height = menu->line_height; + menu->height += menu->height * menu->item_count; + } } static int compare_items(const void *a, const void *b) { ```

fictitiousexistence referenced this issue from a pull request that will close it,

2025-11-02 23:12:01 +01:00

Set height to item count if less items than lines #67

adnano referenced this issue from a commit

2025-11-19 02:09:14 +01:00

Limit number of menu lines by item count

adnano closed this issue

2025-11-19 02:09:14 +01:00