Glance

Wrong assertion method

Bug #1989268 reported by Takashi Natsume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
Takashi Natsume

Bug Description

There is misuse of an assert statement in the master.

https://opendev.org/openstack/glance/src/commit/d7db4e56231059a15d4451c0eaa417c9375162a7/glance/tests/unit/v2/test_image_data_resource.py#L256

       mock_enforce.has_calls(expected_call)

'has_calls' should be 'assert_has_calls'.

Takashi Natsume (natsume-takashi)
Changed in glance:
assignee: nobody → Takashi Natsume (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/glance/+/856922

Changed in glance:
status: New → In Progress
Takashi Natsume (natsume-takashi)
summary: - Misuse of assert statement
+ Wrong assertion method
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.opendev.org/c/openstack/glance/+/856922
Committed: https://opendev.org/openstack/glance/commit/5d9cd0e711dae15bccd4012ceed3a8e16cb403e9
Submitter: "Zuul (22348)"
Branch: master

commit 5d9cd0e711dae15bccd4012ceed3a8e16cb403e9
Author: Takashi Natsume <email address hidden>
Date: Sun Sep 11 13:44:04 2022 +0900

    Fix a wrong assertion method

    Replace 'has_calls' with 'assert_has_calls'.

    Change-Id: I0af1e8cd33eb7785aeffa1ac774063303ffbb090
    Closes-Bug: 1989268
    Signed-off-by: Takashi Natsume <email address hidden>

Changed in glance:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 26.0.0.0b2

This issue was fixed in the openstack/glance 26.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.