Closed Bug 1921951 Opened 1 year ago Closed 1 year ago

Vertical tabs list does not scroll to show new background tabs

Categories

(Firefox :: Sidebar, defect, P2)

Firefox 133
defect

Tracking

()

VERIFIED FIXED
135 Branch
Tracking Status
firefox133 --- disabled
firefox134 --- disabled
firefox135 --- disabled
firefox136 --- verified
firefox137 --- verified

People

(Reporter: ke5trel, Assigned: mauro)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(3 files)

STR:

  1. Start with sidebar.verticalTabs = true and sidebar.revamp = true.
  2. Create many tabs (Ctrl+T) so the tab list overflows.
  3. Select the first tab and scroll to the bottom of the list.
  4. Middle-click a link or right-click > "Open Link in New Tab".

Expected:
Tab list scrolls to the start to show the new tab like with horizontal tabs.

Actual:
Scroll position does not change and the new tabs are not shown.

It works when creating new tabs in the foreground (eg Shift + middle-click) but not in the background.

This will need to be fixed in _notifyBackgroundTab.

Whiteboard: [fidefe-sidebar]
Severity: -- → S3
Priority: -- → P2
Priority: P2 → P3
Duplicate of this bug: 1927036
Duplicate of this bug: 1937418
Assignee: nobody → sclements
Status: NEW → ASSIGNED
Priority: P3 → P2

Hi! Im the dev of zen browser and I would like to know if I can tackle down this issue? I've already found a solution fot it, id like to start contributing to firefox! Please let me know if I can submit a PR. Thanks!

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5ddfa4c882b5 Added support for vertical tabbar scrolling r=tabbrowser-reviewers,dao
Attachment #9445751 - Attachment description: WIP: Bug 1921951 - Added support for vertical tabbar scrolling → Bug 1921951 - Added support for vertical tabbar scrolling

(In reply to Mauro B from comment #4)

Hi! Im the dev of zen browser and I would like to know if I can tackle down this issue? I've already found a solution fot it, id like to start contributing to firefox! Please let me know if I can submit a PR. Thanks!

Welcome Mauro, and thank you for contributing! Great work on Zen Browser!

Assignee: sclements → mau.b

Sorry about that! Still learning. Should be ready now πŸ‘

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Flags: needinfo?(sclements)
Resolution: INVALID → ---
Attachment #9445757 - Attachment description: WIP: Bug 1921951 - Added support for vertical tabbar scrolling (Fixed linter errors) → Bug 1921951 - Fixed linter errors.
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a9d5d105295 Added support for vertical tabbar scrolling r=tabbrowser-reviewers,dao https://hg.mozilla.org/integration/autoland/rev/043380715c7b Fixed linter errors. r=tabbrowser-reviewers,dao
Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Mauro, for future reference if this bug was already assigned to someone you should not essentially take over the bug by pushing a patch to it - that's not cool.

Oh, sorry... I didn't know. Im new in this, I already had a fix so I thought of asking if y'all would like it

(In reply to Mauro B from comment #15)

Oh, sorry... I didn't know. Im new in this, I already had a fix so I thought of asking if y'all would like it

Contributions are most welcome but please take a look at our guidelines. If someone is assigned a bug already, it means they are working on their own solution.

Flags: qe-verify+

Managed to reproduce the issue on Firefox 133.0a1 (2024-10-06) (64-bit), under Windows 11x64.
The issue is no longer reproducible on Firefox 137.0a1 (2025-02-07), or on Firefox 136.0b2.
Tests were performed under Windows 11 x64 ,macOS 10.15 and Ubuntu 22.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: