Closed
Bug 1894240
Opened 1 year ago
Closed 1 year ago
Reduce string conversion for notification events?
Categories
(Core :: DOM: Notifications, task, P3)
Core
DOM: Notifications
Tracking
()
RESOLVED
FIXED
135 Branch
| Tracking | Status | |
|---|---|---|
| firefox135 | --- | fixed |
People
(Reporter: saschanaz, Assigned: developer.ruhan)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
For example, we convert scope into UTF8 and then back to UTF16, it doesn't seem useful.
https://searchfox.org/mozilla-central/rev/0916ef0172ce5b2a72749b659da8ad95f637ef42/dom/notification/Notification.cpp#1238
https://searchfox.org/mozilla-central/rev/0916ef0172ce5b2a72749b659da8ad95f637ef42/dom/serviceworkers/ServiceWorkerManager.cpp#1149
|
Reporter | |
Comment 1•1 year ago
|
||
This should be about just changing string types.
Keywords: good-first-bug
Is this bug still available to take? If so can I work on it?
Flags: needinfo?(krosylight)
|
|
Reporter | |
Comment 3•1 year ago
|
||
Yes 👍🏻🙏🏻
Assignee: nobody → developer.ruhan
Flags: needinfo?(krosylight)
|
||
Comment 4•1 year ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: developer.ruhan → nobody
|
||
Updated•1 year ago
|
Severity: -- → S3
Priority: -- → P3
I think I was unassigned on this bug. I was a bit busy in the last month; however I have implemented a solution to this bug and I just have to submit it. I would like to request to be reassigned to this.
|
|
||
Updated•1 year ago
|
Assignee: nobody → developer.ruhan
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/672ddcb686f2
Reduced string conversion for notification events. r=saschanaz
|
||
Comment 8•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox135:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•