Closed Bug 2014512 Opened 1 month ago Closed 1 month ago

Enable `dom.media.pseudo-classes.enabled` on Nightly

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
149 Branch
Tracking Status
relnote-firefox --- 149+
firefox149 --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

No description provided.
Pushed by alwu@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/98f1eaffcc15 https://hg.mozilla.org/integration/autoland/rev/7261bf10d4d8 enable `dom.media.pseudo-classes.enabled` on Nightly. r=media-playback-reviewers,padenot
Pushed by csabou@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/04e8ba9b990c https://hg.mozilla.org/integration/autoland/rev/6ad6c4f493c8 Revert "Bug 2014512 - enable `dom.media.pseudo-classes.enabled` on Nightly. r=media-playback-reviewers,padenot" for causing wpt failures.

Backed out for causing wpt failures.

Push with failures

Failure log

Backout link

Flags: needinfo?(alwu)

Looks like we just need to annotate some expected "timeout" and "notrun" statuses in WPT /css/selectors/invalidation/media-loading-pseudo-classes-in-has.html

The test implementation is incorrect, which results in no stalled event being
dispatched and causes the test to time out. This issue should be fixed in
bug 2015583.

Flags: needinfo?(alwu)
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch

Does it need a mention in our nightly release notes? Thanks

Flags: needinfo?(alwu)

Yes, that sounds good to me. Thanks!

Flags: needinfo?(alwu)

Please request the addition by following our Bugzilla Release Notes nomination documentation, thanks!
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination#Nomination_in_Bugzilla

Flags: needinfo?(alwu)

Release Note Request (optional, but appreciated)
[Why is this notable]: Enable a new feature on Nightly (currently Nightly only and will have another bug to flip pref for all channels)
[Affects Firefox for Android]: Yes
[Suggested wording]: Enabled media element pseudo-classes, such as :playing, :paused..e.t.c
[Links (documentation, blog post, etc)]: https://bugzilla.mozilla.org/show_bug.cgi?id=2013367#c0

relnote-firefox: --- → ?
Flags: needinfo?(alwu)

Note added to 149 release notes with this wording;

Enabled media element pseudo-classes, such as :playing, :paused…

I am keeping the relnote-firefox? flag set until we include this note in our final 149 release notes, thanks.

Type: task → enhancement

This should also be mentioned at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features. So adding the dev-doc-needed flag.

Alastor, once you file the bug for shipping the new pseudo-classes, don't forget to add the dev-doc-needed flag and request the addition to the release notes there, as well, so it's not forgotten to document the shipping.

Sebastian

Keywords: dev-doc-needed
QA Whiteboard: [qa-triage-done-c150/b149]

Related issues and pull requests

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: