Closed Bug 1997647 Opened 2 months ago Closed 1 month ago

Focus outlines on New Tab Lists widget <fieldset> and "Completed" <summary> do not use correct color theme styling

Categories

(Firefox :: New Tab Page, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: ini, Assigned: dgrant)

Details

Attachments

(3 files)

Attached image completed_summary.png

Prefs:

  • Set browser.newtabpage.activity-stream.widgets.system.enabled to true
  • Set browser.newtabpage.activity-stream.widgets.lists.enabled to true
  • Set browser.newtabpage.activity-stream.widgets.system.lists.enabled to true
  • In about:addons, enable Dark theme

STR:

  1. Add 3+ tasks to the Lists widget until it becomes scrollable
  2. Use the tab key within the Lists widget until the <fieldset> element is reached (or check focus-visible styles using dev tools)
  3. Continue tabbing until the "Completed" <summary> element is reached
  4. Observe the focus outline colors

Expected:
The focus outlines should use the light blue color for dark theme, consistent with other buttons in the Lists widget.

Issue:
The focus outline colors are incorrect.

Suggested fix:
Use the --focus-outline token from the design system. See Bug 1986927 for a similar fix.

Attached image fieldset.png
Assignee: nobody → dgrant
Status: NEW → ASSIGNED
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7b4321303560 https://hg.mozilla.org/integration/autoland/rev/b572116c70f6 Revert "Bug 1997647 fix outline for list widget r=home-newtab-reviewers,nbarrett" for causing stylelint failures.
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Flags: needinfo?(dgrant)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: