Focus outlines on New Tab Lists widget <fieldset> and "Completed" <summary> do not use correct color theme styling
Categories
(Firefox :: New Tab Page, defect, P3)
Tracking
()
People
(Reporter: ini, Assigned: dgrant)
Details
Attachments
(3 files)
Prefs:
- Set
browser.newtabpage.activity-stream.widgets.system.enabledto true - Set
browser.newtabpage.activity-stream.widgets.lists.enabledto true - Set
browser.newtabpage.activity-stream.widgets.system.lists.enabledto true - In
about:addons, enable Dark theme
STR:
- Add 3+ tasks to the Lists widget until it becomes scrollable
- Use the tab key within the Lists widget until the <fieldset> element is reached (or check
focus-visiblestyles using dev tools) - Continue tabbing until the "Completed" <summary> element is reached
- Observe the focus outline colors
Expected:
The focus outlines should use the light blue color for dark theme, consistent with other buttons in the Lists widget.
Issue:
The focus outline colors are incorrect.
Suggested fix:
Use the --focus-outline token from the design system. See Bug 1986927 for a similar fix.
| Reporter | ||
Comment 1•2 months ago
|
||
Updated•2 months ago
|
Comment 5•1 month ago
|
||
Backed out for causing stylelint failures.
Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/b572116c70f6fcde2c89693d9e946e5cd4ddb4b3
Failure log: https://treeherder.mozilla.org/logviewer?job_id=538087724&repo=autoland&task=Zl6mj-QUSXePvBj4CFkgww.0&lineNumber=388
Also this bc failures.
Failure log.
(In reply to Atila Butkovits from comment #5)
Backed out for causing stylelint failures.
Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/b572116c70f6fcde2c89693d9e946e5cd4ddb4b3
Failure log: https://treeherder.mozilla.org/logviewer?job_id=538087724&repo=autoland&task=Zl6mj-QUSXePvBj4CFkgww.0&lineNumber=388
Hello, I've gone ahead and taken a look and addressed the issues. Thank you.
Comment 9•1 month ago
|
||
| bugherder | ||
Description
•