➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: PyDict_UpdateFromSeq2() unused
Type: Stage:
Components: Interpreter Core Versions: Python 2.2
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: tim.peters Nosy List: gvanrossum, nnorwitz, tim.peters
Priority: normal Keywords:

Created on 2001-12-11 03:16 by nnorwitz, last changed 2022-04-10 16:04 by admin. This issue is now closed.

Messages (6)
msg8097 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2001-12-11 03:16 
static int PyDict_UpdateFromSeq2() in
Objects/dictobject.c is not used.  
Should it be used or removed?
msg8098 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2001-12-11 03:26 
Logged In: YES 
user_id=6380

Tim? It's static but the name looks public???
msg8099 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2001-12-11 03:55 
Logged In: YES 
user_id=31435

PyDict_{Update,Merge}FromSeq2 are parallel to PyDict_
{Update,Merge}, taking a sequence of 2-sequences instead of 
a dict.  The former are both static, and unadvertised in 
the header file, just because it wasn't clear to me at the 
time whether we wanted to bloat the public API with them, 
and I wanted to move on to the next bug.  If you care to 
pronounce that they're not public API material, happy to 
rename merge2 and nuke update2 (or, if they are, to make 
them extern and advertise them).
msg8100 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2001-12-11 04:10 
Logged In: YES 
user_id=6380

let's talk tomorrow.
msg8101 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2001-12-11 16:42 
Logged In: YES 
user_id=6380

OK, let's make PyDict_MergeFromSeq2 public, and nuke
PyDict_UpdateFromSeq2. (If I had to do it over again, I
wouldn't make PyDict_Update public, but only PyDict_Merge --
but that's too late.)
msg8102 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2001-12-11 18:52 
Logged In: YES 
user_id=31435

Closed by

Doc/api/concrete.tex; new revision: 1.5
Include/dictobject.h; new revision: 2.23
Misc/NEWS; new revision: 1.332
Objects/dictobject.c; new revision: 2.119
History
Date User Action Args
2022-04-10 16:04:45adminsetgithub: 35717
2001-12-11 03:16:12nnorwitzcreate