python-openstackclient

extension show raise TypeError when extension don't exist

Bug #1689233 reported by Rui Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Undecided
Rui Chen

Bug Description

When I input a not-existed extension name to show the details, TypeError is raised, we should use more exact exception message to replace it.

(openstack) extension show devr
'NoneType' object has no attribute 'to_dict'

Rui Chen (kiwik-chenrui)
Changed in python-openstackclient:
assignee: nobody → Rui Chen (kiwik-chenrui)
OpenStack Infra (hudson-openstack)
Changed in python-openstackclient:
status: New → In Progress
Revision history for this message
Rui Chen (kiwik-chenrui) wrote :

Append the patch link:

https://review.openstack.org/#/c/449757/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/449757
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=acc2d106abfb4fed0ff5d0d0c246d69f9ea1758b
Submitter: Jenkins
Branch: master

commit acc2d106abfb4fed0ff5d0d0c246d69f9ea1758b
Author: Ankur Gupta <email address hidden>
Date: Fri Mar 24 12:39:22 2017 -0500

    Refactor Extension show and list command

    1.keep the column display order consist in extension list with
      and without "--long" option.
    2.rework for network extentsion list, openstacksdk return object,
      so the logic should be same with other service.
    3.add some unit test cases, like: extension list --network --long,
      extension list --network --compute, to cover regular use cases.
    4.raise exact exception when network extension don't exist, avoid
      internal TypeError in "extension show" commands.

    Change-Id: I2e23ced80d8da8aa1106b22472db850367b351ce
    Closes-Bug: #1689233

Changed in python-openstackclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-openstackclient 3.12.0

This issue was fixed in the openstack/python-openstackclient 3.12.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.