python-openstackclient

"os port create" command missed some options

Bug #1612136 reported by Nam
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
python-openstackclient
Won't Fix
Undecided
Nam

Bug Description

The "os port create" command missed some options including: [--security-group SECURITY_GROUP | --no-security-groups] [--extra-dhcp-opt EXTRA_DHCP_OPTS] [--qos-policy QOS_POLICY] [--allowed-address-pair ip_address=IP_ADDR[,mac_address=MAC_ADDR] | --no-allowed-address-pairs] [--dns-name DNS_NAME]

====

The option of "os create port command:

usage: openstack port create [-h] [-f {json,shell,table,value,yaml}]
                             [-c COLUMN] [--max-width <integer>] [--noindent]
                             [--prefix PREFIX] --network <network>
                             [--device <device-id>]
                             [--device-owner <device-owner>]
                             [--vnic-type <vnic-type>] [--host <host-id>]
                             [--fixed-ip subnet=<subnet>,ip-address=<ip-address>]
                             [--binding-profile <binding-profile>]
                             [--enable | --disable]
                             [--mac-address <mac-address>]
                             [--security-group <security-group> | --no-security-group]
                             [--project <project>]
                             [--project-domain <project-domain>]
                             <name>

====

The option of "neutron port-create" command:

usage: neutron port-create [-h] [-f {json,shell,table,value,yaml}] [-c COLUMN]
                           [--max-width <integer>] [--noindent]
                           [--prefix PREFIX] [--request-format {json}]
                           [--tenant-id TENANT_ID] [--name NAME]
                           [--description DESCRIPTION]
                           [--fixed-ip subnet_id=SUBNET,ip_address=IP_ADDR]
                           [--device-id DEVICE_ID]
                           [--device-owner DEVICE_OWNER] [--admin-state-down]
                           [--mac-address MAC_ADDRESS]
                           [--vnic-type <direct | direct-physical | macvtap | normal | baremetal>]
                           [--binding-profile BINDING_PROFILE]
                           [--security-group SECURITY_GROUP | --no-security-groups]
                           [--extra-dhcp-opt EXTRA_DHCP_OPTS]
                           [--qos-policy QOS_POLICY]
                           [--allowed-address-pair ip_address=IP_ADDR[,mac_address=MAC_ADDR]
                           | --no-allowed-address-pairs] [--dns-name DNS_NAME]
                           NETWORK

Comparing between those results. "os create port" command missed those options

Tags: network
Nam (namnh)
Changed in python-openstackclient:
assignee: nobody → Nam (namnh)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstackclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/353911

Changed in python-openstackclient:
status: New → In Progress
Revision history for this message
Richard Theis (rtheis) wrote :

FYI: There is an old patch that started some of this work: https://review.openstack.org/#/c/290849/

Revision history for this message
Richard Theis (rtheis) wrote :

Please also include port security options on which were recently added to network commands (https://review.openstack.org/#/c/335550/). These options apply to ports as well.

Revision history for this message
Richard Theis (rtheis) wrote :

I think this bug should focus on options rather than commands. That is, if the option is missing on create, it should be added to set or unset when applicable in the same patch.

Richard Theis (rtheis)
tags: added: network
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/355797
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=66a04abd581e03e5e71a6b755e1b4dce1856ef41
Submitter: Jenkins
Branch: master

commit 66a04abd581e03e5e71a6b755e1b4dce1856ef41
Author: Nguyen Phuong An <email address hidden>
Date: Tue Aug 16 15:07:01 2016 +0700

    Add security groups options to "port create/set/unset"

    This patch adds '--security-group' and '--no-security-group'
    options to "port create", "port set" and "port unset" commands.

    Change-Id: Iff60d8f29227017b0a3966efca6cdecba69abcea
    Partial-Bug: #1612136
    Partially-Implements: blueprint network-commands-options

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/353911
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=df5f12b135f273e3916e7bf300fa7688a180ea02
Submitter: Jenkins
Branch: master

commit df5f12b135f273e3916e7bf300fa7688a180ea02
Author: Nam Nguyen Hoai <email address hidden>
Date: Fri Aug 12 16:00:52 2016 +0700

    Add "dns-name" option to "os port create" and "os port set"

    This patch added a "dns-name" option to
    "os port create" and "os port set" command.

    Change-Id: I360e2c9a1970e64fe17e4561d7618f860b937373
    Co-Authored-By: Ha Van Tu <email address hidden>
    Partial-Bug: #1612136
    Partially-Implements: blueprint network-commands-options

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-openstackclient (master)

Change abandoned by Nguyen Phuong An (<email address hidden>) on branch: master
Review: https://review.openstack.org/355306
Reason: This patch not passed gate, So we'd like clone it to https://review.openstack.org/#/c/419236/. Could you please review it?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/356219
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=8bcfb824c8f2978c9348968d3da1345c45d7b764
Submitter: Jenkins
Branch: master

commit 8bcfb824c8f2978c9348968d3da1345c45d7b764
Author: Nguyen Phuong An <email address hidden>
Date: Wed Aug 17 11:25:13 2016 +0700

    Add 'allowed address pairs' option to 'port create/set/unset'

    This patch adds '--allowed-addres-pair' and '--no-allowed-address-pair'
    options to 'port create', 'port set' and 'port unset' commands.

    Partial-Bug: #1612136
    Closes-Bug: #1638265
    Partially-Implements: blueprint network-commands-options
    Co-Authored-By: Ha Van Tu <email address hidden>
    Change-Id: I08d2269950467a8972a0d0110ed61f5cc7f5ca45

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/419236
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=5ff2cfd042de7afc4323a3b306ff5be1882fba46
Submitter: Jenkins
Branch: master

commit 5ff2cfd042de7afc4323a3b306ff5be1882fba46
Author: Ha Van Tu <email address hidden>
Date: Thu Jan 12 09:57:53 2017 +0700

    Add "qos-policy" option to "port create" & "port set"

    This patch adds "qos-policy" option to "port create" command,
    and "qos-policy", "no-qos-policy" options to "port set" command
    and "qos-policy" option to "port unset".

    Change-Id: I78072e1ff0dd30a2e23a0fb833ce6ab5cf246016
    Co-Authored-By: Nguyen Phuong An <email address hidden>
    Co-Authored-By: Rodolfo Alonso Hernandez <email address hidden>
    Partial-Bug: #1612136
    Partially-Implements: blueprint network-commands-options

Artem Goncharov (gtema)
Changed in python-openstackclient:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.