DC++

virtual directory sizes are not displayed correctly

Bug #226441 reported by endator on 2008-05-04

Affects		Status	Importance	Assigned to	Milestone
	DC++	Fix Released	Low	Unassigned

Bug Description

version 0.706
on the shared directory tab in settings, all directories for a virtual name are showing the total size of the virtual folder, not the individual folder size

Tags:

Jacek Sieka (arnetheduck) on 2008-05-05

Changed in dcplusplus:
importance:	Undecided → Low
status:	New → Confirmed

Revision history for this message

Fredrik Ullner (ullner) wrote on 2013-08-08:

dcpp_uploadvirtualsize.diff Edit (1.7 KiB, text/plain)

Fix for the bug.

I don't know if the function getShareSize() should instead be fixed (instead of introducing another function), but there may other components that rely on the current behaviour.

Revision history for this message

Fredrik Ullner (ullner) wrote on 2013-08-08:

dcpp_uploadvirtualsize.diff Edit (1.7 KiB, text/plain)

Looks like I generated the diff file too quickly, had a missing paranthesis.

Fredrik Ullner (ullner) on 2013-08-10

Changed in dcplusplus:
status:	Confirmed → In Progress

Revision history for this message

poy (poy) wrote on 2013-08-11:

getShareSize can indeed be fixed instead of the new addition; that size column in settings is its only use.

i am wary of iterating through every file... before pushing this in, i would like to know how well it fares for users with several thousand files. if opening settings freezes for more than say, 2 s, a better solution must be found (i can't think of any better way, unfortunately).

Revision history for this message

eMTee (realprogger) wrote on 2013-08-11:

With cca. 30k files shared for me it takes 8 seconds to open the settings.

Fredrik Ullner (ullner) on 2013-11-03

Changed in dcplusplus:
status:	In Progress → Confirmed

Fredrik Ullner (ullner) on 2013-11-30

tags:

added: core

Revision history for this message

eMTee (realprogger) wrote on 2024-07-02:

A fix is committed that avoids mass string comparsions and adds a little overhead only in counting the folders and files in the top merged folder of the virtual shares.