DC++

[ADC] MSGs containing the field ME are not displayed properly

Bug #180321 reported by Fredrik Ullner on 2008-01-04

2

Affects		Status	Importance	Assigned to	Milestone
	DC++	Fix Released	Low	Unassigned

Bug Description

When sending a MSG in an ADC hub that contain the ME field (for "* user says"), DC++ does not properly parse and display it.

Fredrik Ullner (ullner) on 2008-01-04

Changed in dcplusplus:
importance:	Undecided → Low

Revision history for this message

poy (poy) wrote on 2008-01-29:

#1

Patch Edit (5.0 KiB, text/plain)

*untested* patch that adds a bool in the Message and PrivateMessage listeners.

Revision history for this message

poy (poy) wrote on 2008-01-29:

#2

Patch 2 Edit (5.1 KiB, text/plain)

same patch, but adds a space after the star. tested.

Revision history for this message

poy (poy) wrote on 2008-01-29:

#3

Patch 3 Edit (10.0 KiB, text/plain)

this patch includes the previous patch and adds parsing of "/me <msg>" for ADC hubs, in which the message is stripped from the "/me " part and and an ME flag is added.
this patch also fixes a behavior of the private frame that removes the slash from unknown /commands.

Revision history for this message

Jacek Sieka (arnetheduck) wrote on 2008-02-02:

#4

I applied patch 2...I think it would be more clean to add a flag to hubMessage instead of parsing in adchub...this way it's the same in both directions...

Jacek Sieka (arnetheduck) on 2008-02-02

Changed in dcplusplus:
status:	New → In Progress

Revision history for this message

poy (poy) wrote on 2008-02-03:

#5

Patch 4 Edit (11.3 KiB, text/plain)

yes, it looked weird that the parsing was being done in the core while all other /commands are parsed in the GUI. now, the parsing happens in WinUtil and a bool is dispatched to the hubMessage and privateMessage functions.
note that with this patch, "/me a" in an NMDC hub would send only "a"; the "/me " part will be lost.

Revision history for this message

Jacek Sieka (arnetheduck) wrote on 2008-02-09:

#6

I readded the /me on nmdc hubs...some clients parse that to rewrite message so we might as well please them...

Changed in dcplusplus:
status:	In Progress → Fix Committed

MikeJJ (mrmikejj) on 2008-03-16

Changed in dcplusplus:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

Add patch

Remote bug watches

Bug watches keep track of this bug in other bug trackers.