OpenStack Dashboard (Horizon)

It is impossible to access assets of the theme not present in AVAILABLE_THEMES

Bug #1564543 reported by Timur Sufiev on 2016-03-31

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Medium	Unassigned	OpenStack Dashboard (Horizon) pike-3

Bug Description

Currently themes machinery works in such way that if we rely on default theme in our branded theme, we have to include them both into AVAILABLE_THEMES setting, otherwise default theme assets will be unavailable and the branded theme assets compilation will fail. On the other hand, mentioning them both leads to theme picker being shown - which we would like to avoid (per marketing wish). Is it possible to show less themes for switching (ideally, one) and still be able to reference other themes assets?

Timur Sufiev (tsufiev-x) on 2016-03-31

Changed in horizon:
importance:	Undecided → Medium

Diana Whitten (hurgleburgler) on 2016-03-31

Changed in horizon:
assignee:	nobody → Diana Whitten (hurgleburgler)
status:	New → In Progress
milestone:	none → newton-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-17: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/317757

Rob Cresswell (robcresswell-deactivatedaccount) on 2016-06-03

Changed in horizon:
milestone:	newton-1 → newton-2

Rob Cresswell (robcresswell-deactivatedaccount) on 2016-07-21

Changed in horizon:
milestone:	newton-2 → newton-3

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-28: Change abandoned on horizon (master)

Change abandoned by Diana Whitten (<email address hidden>) on branch: master
Review: https://review.openstack.org/317757
Reason: Maybe I can pick this up at a later time.

Rob Cresswell (robcresswell-deactivatedaccount) on 2016-08-25

Changed in horizon:
assignee:	Diana Whitten (hurgleburgler) → nobody
milestone:	newton-3 → next
status:	In Progress → Confirmed

OpenStack Infra (hudson-openstack) on 2017-05-25

Changed in horizon:
assignee:	nobody → Ivan Kolodyazhny (e0ne)
status:	Confirmed → In Progress

OpenStack Infra (hudson-openstack) on 2017-07-26

Changed in horizon:
assignee:	Ivan Kolodyazhny (e0ne) → Rob Cresswell (robcresswell)

Rob Cresswell (robcresswell-deactivatedaccount) on 2017-07-26

Changed in horizon:
milestone:	next → pike-3

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-07-26: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/317757
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=958e522d402615779609b5d660a545198cfa8a28
Submitter: Jenkins
Branch: master

commit 958e522d402615779609b5d660a545198cfa8a28
Author: Diana Whitten <email address hidden>
Date: Tue May 17 15:06:05 2016 -0700

Added SELECTABLE_THEMES setting

    Currently themes machinery works in such way that if we rely on
    default theme in our branded theme, we have to include them both into
    AVAILABLE_THEMES setting, otherwise default theme assets will be
    unavailable and the branded theme assets compilation will fail. On
    the other hand, mentioning them both leads to theme picker being
    shown - which we would like to avoid (per marketing wish).

SELECTABLE_THEMES setting was added to allow limiting the user facing
themes by configuration.

Closes-bug: #1564543
Co-Authored-By: Ivan Kolodyazhny <email address hidden>

Change-Id: Ic00a9201d2d352685b1089a37a25987b75d6636d