test/index.test.ts (1)

171-221: ⚡ Quick win

Add a dedicated test for publicURL vs PORTLESS_URL precedence

These tests cover additionalURLs precedence well, but they don’t directly assert the PR’s stated contract that explicit publicURL overrides PORTLESS_URL. A focused test here would lock that behavior and prevent regressions.

Suggested test addition

+  test("prefers explicit publicURL over PORTLESS_URL fallback", async () => {
+    process.env.PORTLESS_URL = "https://fallback.portless.dev";
+    listener = await listen(handle, {
+      hostname: "localhost",
+      publicURL: "https://configured.example.com",
+      additionalURLs: [{ title: "Portless", env: "PORTLESS_URL" }],
+    });
+
+    const urls = await listener.getURLs();
+    expect(urls).toEqual(
+      expect.arrayContaining([
+        expect.objectContaining({
+          url: "https://configured.example.com",
+        }),
+      ]),
+    );
+  });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/index.test.ts` around lines 171 - 221, Add a focused unit test that
ensures an explicit publicURL passed to listen takes precedence over the
PORTLESS_URL env var: set process.env.PORTLESS_URL to a fallback value, call
listen(handle, { hostname: "localhost", publicURL:
"https://explicit.example.com" }), then assert listener.getURLs() contains an
object with type "public" and url "https://explicit.example.com" and does not
contain the fallback PORTLESS_URL; use the same pattern as existing
additionalURLs tests and reference listen, publicURL, process.env.PORTLESS_URL,
handle, and listener.getURLs to locate where to add the test.

src/types.ts (1)

188-203: ⚡ Quick win

Require at least one source field in AdditionalURL

AdditionalURL currently allows entries with only title, which makes invalid config type-check. Tightening this prevents no-op/undefined URL entries from reaching runtime.

Proposed type tightening

-export interface AdditionalURL {
-  /**
-   * The label shown in the CLI output.
-   */
-  title: string;
-
-  /**
-   * Static URL to show.
-   */
-  url?: string;
-
-  /**
-   * Environment variable that contains the URL to show.
-   */
-  env?: string;
-}
+export type AdditionalURL =
+  | {
+      /**
+       * The label shown in the CLI output.
+       */
+      title: string;
+      /**
+       * Static URL to show.
+       */
+      url: string;
+      /**
+       * Optional fallback env when url is absent in downstream overrides.
+       */
+      env?: string;
+    }
+  | {
+      /**
+       * The label shown in the CLI output.
+       */
+      title: string;
+      /**
+       * Environment variable that contains the URL to show.
+       */
+      env: string;
+      /**
+       * Optional explicit URL; when provided, runtime can still prefer url.
+       */
+      url?: string;
+    };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/types.ts` around lines 188 - 203, AdditionalURL currently allows only
title and can be empty at runtime; update the type to require at least one
source by replacing the interface with a union that combines title with either a
required url or a required env (e.g., make AdditionalURL = { title: string } &
({ url: string; env?: string } | { env: string; url?: string })), and adjust any
usages of AdditionalURL to satisfy the stronger type (functions or places
creating AdditionalURL objects must provide url or env).

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

test/index.test.ts (1)

171-235: ⚡ Quick win

Add coverage for the implicit default Portless path (extraURLs omitted).

The suite validates explicit extraURLs, but not the new default fallback behavior wired in src/listen.ts (defaulting to PORTLESS_URL when extraURLs is absent).

Suggested test

   describe("extra urls", () => {
+    test("includes default Portless url when extraURLs is omitted", async () => {
+      process.env.PORTLESS_URL = "https://default.portless.dev";
+      listener = await listen(handle, {
+        hostname: "localhost",
+      });
+
+      expect(await listener.getURLs()).toEqual(
+        expect.arrayContaining([
+          expect.objectContaining({
+            type: "extra",
+            title: "Portless",
+            url: "https://default.portless.dev",
+          }),
+        ]),
+      );
+    });
+
     test("includes env-backed urls (resolved at getURLs time)", async () => {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/index.test.ts` around lines 171 - 235, Add a test to cover the implicit
default Portless extra URL when extraURLs is omitted: call listen(handle, {
hostname: "localhost" }) (no extraURLs), set process.env.PORTLESS_URL (either
before or after listen to assert lazy resolution), then call listener.getURLs()
and assert the returned array contains an object with type: "extra", title:
"Portless", and url equal to process.env.PORTLESS_URL; ensure you use the
existing listener variable and clean up/reset process.env.PORTLESS_URL after the
test.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes